-
Notifications
You must be signed in to change notification settings - Fork 335
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support Class field declarations #438
base: master
Are you sure you want to change the base?
Add support Class field declarations #438
Conversation
What is wrong with CL |
c0a6c15
to
3e49b49
Compare
Looking at the build logs versus https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Classes#browser_compatibility, the bug is obvious. Classes field support started in Node 12, but the .travis.yml file mandates testing against Node 6, 8, and 10. |
No, the Node version is irrelevant here. The parser used is acorn, and the issue is that escodegen/test/compare-acorn-es2019.js Lines 39 to 45 in 7a48a21
And here: escodegen/test/compare-acorn-es2019.js Lines 58 to 64 in 7a48a21
|
I added a PR that supersedes this with more tests that pass: #465 |
This is required because Acorn uses acorn-class-fields.