Skip to content
Draft
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
84 changes: 83 additions & 1 deletion escodegen.js
Original file line number Diff line number Diff line change
Expand Up @@ -2434,8 +2434,90 @@

ModuleSpecifier: function (expr, precedence, flags) {
return this.Literal(expr, precedence, flags);
}
},

JSXIdentifier: function (expr, precedence, flags) {
return expr.name;
},

JSXMemberExpression: function (expr, precedence, flags) {
var result = [];
result.push(this.generateExpression(expr.object, precedence, flags));
result.push('.');
result.push(this.generateExpression(expr.property, precedence, flags));
return result;
},

JSXNamespacedName: function (expr, precedence, flags) {
var result = [];
result.push(this.generateExpression(expr.namespace, precedence, flags));
result.push(':');
result.push(this.generateExpression(expr.name, precedence, flags));
return result;
},

JSXEmptyExpression: function (expr, precedence, flags) {
return '';
},

JSXExpressionContainer: function (expr, precedence, flags) {
return ['{', this.generateExpression(expr.expression, precedence, flags), '}'];
},

JSXOpeningElement: function (expr, precedence, flags) {
var result, i, iz;
result = ['<'];
result.push(this.generateExpression(expr.name, precedence, flags));
if (expr.attributes) {
for(i = 0, iz = expr.attributes.length; i < iz; ++i) {
result.push(' ');
result.push(this.generateExpression(expr.attributes[i], precedence, flags));
}
}
result.push(expr.selfClosing ? ' />' : '>');
return result;
},

JSXClosingElement: function (expr, precedence, flags) {
return ['</', this.generateExpression(expr.name, precedence, flags), '>'];
},

JSXAttribute: function (expr, precedence, flags) {
var result = [];
result.push(this.generateExpression(expr.name, precedence, flags));
result.push('=');
if (expr.value.type === 'Literal') {
result.push(this.generateExpression(expr.value, precedence, flags));
return result;
}
if (expr.value.type === 'JSXExpressionContainer') {
result.push(this.generateExpression(expr.value.expression, precedence, flags));
return result;
}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You also need to handle expr.value.type === 'JSXElement' here.

> require('escodegen').generate(require('esprima').parse('(<Foo bar=<Quux/>/>)', {jsx: true}));
'<Foo undefined />;'

And JSXFragment as well, if you go for that: https://github.com/facebook/jsx/blob/master/AST.md#jsx-attributes

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Totally forgot about boolean attributes, good catch 👍

},

JSXSpreadAttribute: function (expr, precedence, flags) {
return ['{...', this.generateExpression(expr.argument, precedence, flags), '}'];
},

JSXText: function (expr, precedence, flags) {
return expr.value;
},

JSXElement: function (expr, precedence, flags) {
var result, i, iz;
result = [];
result.push(this.generateExpression(expr.openingElement, precedence, flags));
if (expr.children) {
for(i = 0, iz = expr.children.length; i < iz; ++i) {
result.push(this.generateExpression(expr.children[i], precedence, flags));
}
}
if (expr.closingElement) {
result.push(this.generateExpression(expr.closingElement, precedence, flags));
}
return result;
}
};

merge(CodeGenerator.prototype, CodeGenerator.Expression);
Expand Down
2 changes: 1 addition & 1 deletion package.json
Original file line number Diff line number Diff line change
Expand Up @@ -30,9 +30,9 @@
"url": "http://github.com/estools/escodegen.git"
},
"dependencies": {
"esprima": "^4.0.1",
"estraverse": "^4.2.0",
"esutils": "^2.0.2",
"esprima": "^3.1.3",
"optionator": "^0.8.1"
},
"optionalDependencies": {
Expand Down
Loading