feat: add BigInt support
#387
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
@michaelficarra what should I do that this PR has been merged? Add tests? My project requires the support of bigint |
|
|
||
| // BigInt, eg: 1n | ||
| if (typeof expr.bigint === 'string') { | ||
| return expr.raw; |
Member
There was a problem hiding this comment.
The raw field is not guaranteed to be there.
Suggested change
| return expr.raw; | |
| return expr.bigint + 'n'; |
Member
|
@sanex3339 Yes please. This PR would need tests before being merged. |
Contributor
|
@michaelficarra Tests added in #421. |
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.