Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Nested search #2171

Merged
merged 28 commits into from
Jan 24, 2025
Merged

Nested search #2171

merged 28 commits into from
Jan 24, 2025

Conversation

DmitryAstafyev
Copy link
Collaborator

Features

  • adds search through search results

@DmitryAstafyev DmitryAstafyev marked this pull request as draft January 8, 2025 14:46
@DmitryAstafyev DmitryAstafyev marked this pull request as ready for review January 10, 2025 09:38
@DmitryAstafyev DmitryAstafyev mentioned this pull request Jan 22, 2025
Closed
marcmo
marcmo reviewed Jan 23, 2025
View reviewed changes
Copy link
Member

@marcmo marcmo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM...but where are the tests for search_nested_match?

@DmitryAstafyev
Copy link
Collaborator Author

DmitryAstafyev commented Jan 24, 2025 •
edited
Loading

@marcmo

LGTM...but where are the tests for search_nested_match?

Test Test 8. Assign & search and nested search lives in the context of ts-bindings and included into our testing workflow.

@DmitryAstafyev DmitryAstafyev merged commit b7c827d into esrlabs:master Jan 24, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marcmo marcmo marcmo left review comments

@AmmarAbouZor AmmarAbouZor AmmarAbouZor approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@DmitryAstafyev @marcmo @AmmarAbouZor