Skip to content

fix(usb_host_test): Fix cmake warninings about private include#459

Merged
peter-marcisovsky merged 1 commit intomasterfrom
fix/cmake_warnings_test_app
Apr 10, 2026
Merged

fix(usb_host_test): Fix cmake warninings about private include#459
peter-marcisovsky merged 1 commit intomasterfrom
fix/cmake_warnings_test_app

Conversation

@peter-marcisovsky
Copy link
Copy Markdown
Collaborator

@peter-marcisovsky peter-marcisovsky commented Apr 1, 2026

Removing CMake warning when building target tests in host/usb/test/target_test

CMake Warning at /opt/esp/idf/tools/cmake/component_validation.cmake:86 (message):
Include directory '/__w/esp-usb/esp-usb/host/usb/private_include' belongs
to component usb but is being used by component common.  It is recommended
to define the component dependency for 'common' on the component usb, i.e.
'idf_component_register(...  REQUIRES usb)' in the CMakeLists.txt of
common, and specify the included directory as idf_component_register(...
INCLUDE_DIRS <dir relative to component>) in the CMakeLists.txt of
component usb.
Call Stack (most recent call first):
/opt/esp/idf/tools/cmake/component_validation.cmake:130 (__component_validation_check_include_dirs)
/opt/esp/idf/CMakeLists.txt:353 (__component_validation_run_checks)

Description

Adding USB component's private include using target_include_directories instead of INCLUDE_DIRS

Related


Checklist

Before submitting a Pull Request, please ensure the following:

  • 🚨 This PR does not introduce breaking changes.
  • All CI checks (GH Actions) pass.
  • Documentation is updated as needed.
  • Tests are updated or added as necessary.
  • Code is well-commented, especially in complex areas.
  • Git history is clean — commits are squashed to the minimum necessary.

@peter-marcisovsky peter-marcisovsky self-assigned this Apr 1, 2026
@peter-marcisovsky peter-marcisovsky added Component: usb_host Issue affects usb_host component BUILD_AND_TEST_ALL_APPS Build and test all apps even if no related code has changed. labels Apr 1, 2026
@peter-marcisovsky peter-marcisovsky force-pushed the fix/cmake_warnings_test_app branch from d7b571b to 891c92a Compare April 7, 2026 13:12
@peter-marcisovsky peter-marcisovsky removed the BUILD_AND_TEST_ALL_APPS Build and test all apps even if no related code has changed. label Apr 7, 2026
@peter-marcisovsky peter-marcisovsky force-pushed the fix/cmake_warnings_test_app branch 2 times, most recently from afc1a95 to ba48fd5 Compare April 9, 2026 06:50
@peter-marcisovsky peter-marcisovsky marked this pull request as ready for review April 9, 2026 08:17
@peter-marcisovsky peter-marcisovsky added the BUILD_AND_TEST_ALL_APPS Build and test all apps even if no related code has changed. label Apr 9, 2026
@peter-marcisovsky peter-marcisovsky merged commit bd41947 into master Apr 10, 2026
90 of 112 checks passed
@peter-marcisovsky peter-marcisovsky deleted the fix/cmake_warnings_test_app branch April 10, 2026 08:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

BUILD_AND_TEST_ALL_APPS Build and test all apps even if no related code has changed. Component: usb_host Issue affects usb_host component

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants