Skip to content

Conversation

redradist
Copy link

@redradist redradist commented Dec 19, 2020

This MR fixes some issues when using code in C++ and also added extra user-defined argument for using for example in C++ wrapper

@CLAassistant
Copy link

CLAassistant commented Dec 19, 2020

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

@redradist redradist changed the base branch from master to nimble-1.2.0-idf-v4.2-afr December 19, 2020 12:40
@redradist redradist changed the base branch from nimble-1.2.0-idf-v4.2-afr to nimble-1.2.0-idf December 19, 2020 12:40
@prasad-alatkar
Copy link

Hi @redradist , most of the changes look specific to upstream NimBLE. It would be really great if you raise PR on mynewt NimBLE first here: https://github.com/apache/mynewt-nimble/pulls

@redradist
Copy link
Author

redradist commented Dec 22, 2020

Hi @redradist , most of the changes look specific to upstream NimBLE. It would be really great if you raise PR on mynewt NimBLE first here: https://github.com/apache/mynewt-nimble/pulls

@prasad-alatkar I've tired first it already apache#697
... But they decided that it is not needed and not useful at that moment and it is a hack (but it is not !!)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants