Skip to content

fix(nimble): Dynamic services fixes #100

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: nimble-1.6.0-idf
Choose a base branch
from
Open

fix(nimble): Dynamic services fixes #100

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0e798b5
fix(nimble): Prevent crash when only using dynamic services
nebkat May 28, 2025
deb4cd2
fix(nimble): Allow connections when only using dynamic services
nebkat May 29, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion nimble/host/src/ble_gatts.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1786,6 +1786,7 @@ int
ble_gatts_conn_can_alloc(void)
{
return ble_gatts_num_cfgable_chrs == 0 ||
ble_gatts_clt_cfg_pool.mp_num_blocks == 0 ||
ble_gatts_clt_cfg_pool.mp_num_free > 0;
}

Expand Down Expand Up @@ -2868,7 +2869,7 @@ int ble_gatts_add_dynamic_svcs(const struct ble_gatt_svc_def *svcs) {
ble_gatts_free_svc_defs();
/* Fill the cache. */
cfg = ble_gatts_get_last_cfg(&ble_gatts_clt_cfgs);
ha = ble_att_svr_find_by_handle(cfg->chr_val_handle - 1);
ha = cfg == NULL ? NULL : ble_att_svr_find_by_handle(cfg->chr_val_handle - 1);
while ((ha = ble_att_svr_find_by_uuid(ha, &uuid.u, 0xffff)) != NULL) {
chr = ha->ha_cb_arg;
allowed_flags = ble_gatts_chr_clt_cfg_allowed(chr);
Expand Down