Fix: Correct the order for complex values real, imag -> imag, real (AEGHB-1452)#252
Open
James-Rhodes wants to merge 1 commit intoespressif:masterfrom
Open
Fix: Correct the order for complex values real, imag -> imag, real (AEGHB-1452)#252James-Rhodes wants to merge 1 commit intoespressif:masterfrom
James-Rhodes wants to merge 1 commit intoespressif:masterfrom
Conversation
This is inline with the documentation online at: https://docs.espressif.com/projects/esp-idf/en/stable/esp32c5/api-guides/wifi.html#wi-fi-channel-state-information
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is inline with the documentation online at:
https://docs.espressif.com/projects/esp-idf/en/stable/esp32c5/api-guides/wifi.html#wi-fi-channel-state-information
Description
This PR fixes the accidental swap of the real and imaginary components for the ESP Crab module. According to the documentation at https://docs.espressif.com/projects/esp-idf/en/stable/esp32c5/api-guides/wifi.html#wi-fi-channel-state-information the imaginary component should come first, followed by the real component. The previous code implementation did the opposite, getting the real and then the imaginary. This PR simply swaps the order to match the documentation and avoid further confusion.
This change was discussed along with several other issues within #246
I believe this bug may also exist within the console_test application specifically here:
However, I do not use this, so could not test it to double check. If I am right and this is a bug. Let me know and I will fix it.
Related
Testing
I have run the application locally on my own board and verified it still works. This change will not change the results as it is only shifting the phase by 90 degrees. However, it makes it consistent with the documentation and avoids future confusion.
Checklist
Before submitting a Pull Request, please ensure the following: