feat(lcd_ili9341): Selectable default initial commands for LCD from three presets. #687

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merged

espzav merged 1 commit into master from feat/lcd_ili9341_init_cmd_sel

Dec 11, 2025

Collaborator

espzav commented Dec 2, 2025 •

edited

Loading

ESP-BSP Pull Request checklist

Version of modified component bumped
CI passing

Change description

Based on PR: feature(ili9341): Add alternative driver configuration for LCD ILI9341 (BSP-638) #513 - Closes feature(ili9341): Add alternative driver configuration for LCD ILI9341 (BSP-638) #513

espzav mentioned this pull request

feature(ili9341): Add alternative driver configuration for LCD ILI9341 (BSP-638) #513

Closed

espzav requested review from PetrESP, igrr and tore-espressif

December 2, 2025 14:20

github-actions bot commented Dec 2, 2025 •

edited

Loading

Test Results

28 tests 28 ✅ 1m 31s ⏱️
5 suites 0 💤
5 files 0 ❌

Results for commit 1298876.

♻️ This comment has been updated with latest results.

Collaborator Author

espzav commented Dec 5, 2025

@tore-espressif @PetrESP PTAL

PetrESP reviewed

View reviewed changes

Collaborator

PetrESP left a comment

Thank you for this PR and I added some comments regarding the bigger picture.

components/lcd/esp_lcd_ili9341/esp_lcd_ili9341.c Outdated Show resolved Hide resolved

components/lcd/esp_lcd_ili9341/esp_lcd_ili9341.c Outdated Show resolved Hide resolved

components/lcd/esp_lcd_ili9341/esp_lcd_ili9341.c Outdated Show resolved Hide resolved

espzav force-pushed the feat/lcd_ili9341_init_cmd_sel branch 2 times, most recently from 1c86328 to b44231c Compare

December 10, 2025 13:42

PetrESP approved these changes

View reviewed changes

Collaborator

PetrESP left a comment

I've added a small suggestion in the documentation but otherwise I am happy with the solution.

components/lcd/esp_lcd_ili9341/README.md Outdated Show resolved Hide resolved

espzav force-pushed the feat/lcd_ili9341_init_cmd_sel branch from b44231c to 619b9a2 Compare

December 10, 2025 14:34


          feat(lcd_ili9341): Selectable default initial commands for LCD from t…

…hree presets.

espzav force-pushed the feat/lcd_ili9341_init_cmd_sel branch from 619b9a2 to 1298876 Compare

December 11, 2025 06:30

github-actions bot commented Dec 11, 2025

⚠️ Build failed for idf_ver=latest index=3

This failure was ignored (continue-on-error enabled).
See details: View build logs

github-actions bot commented Dec 11, 2025

⚠️ Build failed for idf_ver=release-v6.0 index=3

This failure was ignored (continue-on-error enabled).
See details: View build logs

github-actions bot commented Dec 11, 2025

⚠️ Build failed for idf_ver=latest index=2

This failure was ignored (continue-on-error enabled).
See details: View build logs

github-actions bot commented Dec 11, 2025

⚠️ Build failed for idf_ver=release-v6.0 index=5

This failure was ignored (continue-on-error enabled).
See details: View build logs

github-actions bot commented Dec 11, 2025

⚠️ Build failed for idf_ver=release-v6.0 index=2

This failure was ignored (continue-on-error enabled).
See details: View build logs

github-actions bot commented Dec 11, 2025

⚠️ Build failed for idf_ver=latest index=4

This failure was ignored (continue-on-error enabled).
See details: View build logs

github-actions bot commented Dec 11, 2025

⚠️ Build failed for idf_ver=latest index=5

This failure was ignored (continue-on-error enabled).
See details: View build logs

github-actions bot commented Dec 11, 2025

⚠️ Build failed for idf_ver=release-v6.0 index=4

This failure was ignored (continue-on-error enabled).
See details: View build logs

espzav merged commit fc8bd32 into master

70 checks passed

espzav deleted the feat/lcd_ili9341_init_cmd_sel branch

December 11, 2025 09:09

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet