-
Notifications
You must be signed in to change notification settings - Fork 43
Remove the outline on the portal logos including the favicon #479
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
@f-hollow, PTAL. |
|
In addition to the icons you fixed, there are other icons with the outlines:
If we look at it from the perspective of introducing the dark mode, it is not clear if we need to remove the outlines. Can you please add to the description why you are making these updates and what problems they solve? |
@f-hollow, the images with the outlines should be used only in the dark mode. Since the implementation of the dark mode is still under discussion, we need to remove all logo images with outlines to keep consistency with our main portal. |
|
@f-hollow, for some reason, the preview job is not running. |
a0250ad to
a7ffc81
Compare
|
🎉 A preview for this PR is available at: https://preview-developer.espressif.com/pr479/ |
|
@f-hollow, can you please take a look and merge it?
For these, I think they are in cache.
|
Description
This PR removes the outline on the logos used on the Developer Portal. This affects the UI when the icon is small and also adds consistency with other Espressif sites.
This PR also updates authors with the Espressif logo as the author picture to the WebP version.
Related
Testing
Checklist
Before submitting a Pull Request, please ensure the following: