Skip to content

Conversation

@pedrominatel
Copy link
Member

@pedrominatel pedrominatel commented Apr 24, 2025

Description

This PR removes the outline on the logos used on the Developer Portal. This affects the UI when the icon is small and also adds consistency with other Espressif sites.

This PR also updates authors with the Espressif logo as the author picture to the WebP version.

Related

Testing


Checklist

Before submitting a Pull Request, please ensure the following:

  • 🚨 This PR does not introduce breaking changes.
  • All CI checks (GH Actions) pass.
  • Documentation is updated as needed.
  • Tests are updated or added as necessary.
  • Code is well-commented, especially in complex areas.
  • Git history is clean — commits are squashed to the minimum necessary.

@pedrominatel pedrominatel added the needs review Needs someone to be assigned to review label Apr 24, 2025
@pedrominatel pedrominatel requested a review from f-hollow April 24, 2025 17:09
@pedrominatel
Copy link
Member Author

@f-hollow, PTAL.

@f-hollow
Copy link
Collaborator

f-hollow commented Apr 27, 2025

@pedrominatel

In addition to the icons you fixed, there are other icons with the outlines:

  • assets/img/authors/espressif.png
  • Other logos in assets/img/

If we look at it from the perspective of introducing the dark mode, it is not clear if we need to remove the outlines.

Can you please add to the description why you are making these updates and what problems they solve?

@pedrominatel
Copy link
Member Author

@pedrominatel

In addition to the icons you fixed, there are other icons with the outlines:

* `assets/img/authors/espressif.png`

* Other logos in `assets/img/`

If we look at it from the perspective of introducing the dark mode, it is not clear if we need to remove the outlines.

Can you please add to the description why you are making these updates and what problems they solve?

@f-hollow, the images with the outlines should be used only in the dark mode. Since the implementation of the dark mode is still under discussion, we need to remove all logo images with outlines to keep consistency with our main portal.

@pedrominatel
Copy link
Member Author

@f-hollow, for some reason, the preview job is not running.
PTAL on the latest changes.

@github-actions
Copy link

🎉 A preview for this PR is available at: https://preview-developer.espressif.com/pr479/

@pedrominatel
Copy link
Member Author

@f-hollow, can you please take a look and merge it?
The files in PNG format above should be in PNG format.

  • static/android-chrome-192x192.png
  • static/android-chrome-512x512.png
  • static/apple-touch-icon.png
  • static/favicon-16x16.png
  • static/favicon-32x32.png

For these, I think they are in cache.

  • assets/img/authors/espressif.png
  • assets/img/espressif_logo_contour.png
  • assets/img/espressif_logo_contour_only.png

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

needs review Needs someone to be assigned to review

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants