Modified esp_spiffs functions to forward the spiffs error code #208
+27
−9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Changed position of formating check to be able to format the fs even if its not loaded. Required if SPIFFS_MAGIC is used
|
This is good. I've made some changes to the SPIFFS code that probably would be nice to look at at the same time this is reviewed in #210. |
wujiangang
pushed a commit
that referenced
this pull request
Jun 8, 2018
Changed position of formating check to be able to format the fs even if its not loaded. Required if SPIFFS_MAGIC is used Merges #208
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I like the idea to have a working version of spiffs out of the box, but if something goes wrong I want to be able to determine what happend and handle the fault.
Spiffs itself provide these information so they should be forwarded to the user.
Update: Change wrongly labeled ret to res