Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix lsc battletron 3206528 #958

Merged
merged 3 commits into from
Dec 29, 2024
Merged

Conversation

oliv3r
Copy link
Contributor

@oliv3r oliv3r commented Dec 20, 2024

Brief description of the changes

Type of changes

  • New device
  • Update existing device
  • Removing a device
  • General cleanup
  • Other

Checklist:

  • There are no passwords or secrets references in any examples.
    The only exceptions are !secret wifi_ssid and !secret wifi_password.
  • The wifi or ethernet block has no static / manual ip address specified.
  • The first configuration provided should be hardware definitions only.
    A more involved example can be provided in a separate configuration block.

A tiny alignment mistake snook in for whatever reason making the code
non-copy/paste-able.

Signed-off-by: Olliver Schinagl <[email protected]>
From a consistency and 'lets have a few sane defaults' point of view,
it's nice to also add the 'time' module to our nodes.

Signed-off-by: Olliver Schinagl <[email protected]>
Copy link

netlify bot commented Dec 20, 2024

Deploy Preview for esphome-devices ready!

Name Link
🔨 Latest commit 567293a
🔍 Latest deploy log https://app.netlify.com/sites/esphome-devices/deploys/676594c4dbf9b800088843c1
😎 Deploy Preview https://deploy-preview-958--esphome-devices.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
1 paths audited
Performance: 88 (🟢 up 2 from production)
Accessibility: 86 (no change from production)
Best Practices: 100 (no change from production)
SEO: 89 (no change from production)
PWA: 70 (no change from production)
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

@oliv3r
Copy link
Contributor Author

oliv3r commented Dec 20, 2024

I did test it before; and tested it again; no idea why this happened though. Would be nice to store the actual yaml and have it be linted ...

@tekmaven tekmaven merged commit 12d1dbc into esphome:main Dec 29, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants