Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Globe Edison Bulb 34873 #954

Merged
merged 1 commit into from
Dec 29, 2024
Merged

Conversation

CoRfr
Copy link
Contributor

@CoRfr CoRfr commented Dec 18, 2024

Brief description of the changes

Provide support for the Globe Edison Bulb 34873 obtained from Canadian Tire sometime in 2021.

Type of changes

  • New device
  • Update existing device
  • Removing a device
  • General cleanup
  • Other

Checklist:

  • There are no passwords or secrets references in any examples.
    The only exceptions are !secret wifi_ssid and !secret wifi_password.
  • The wifi or ethernet block has no static / manual ip address specified.
  • The first configuration provided should be hardware definitions only.
    A more involved example can be provided in a separate configuration block.

Copy link

netlify bot commented Dec 18, 2024

Deploy Preview for esphome-devices ready!

Name Link
🔨 Latest commit 7e6f964
🔍 Latest deploy log https://app.netlify.com/sites/esphome-devices/deploys/67627d1294e3290008b6bff4
😎 Deploy Preview https://deploy-preview-954--esphome-devices.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
1 paths audited
Performance: 93 (no change from production)
Accessibility: 86 (no change from production)
Best Practices: 100 (no change from production)
SEO: 89 (no change from production)
PWA: 70 (no change from production)
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

@tekmaven tekmaven merged commit 766388f into esphome:main Dec 29, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants