Skip to content

Minor change - Remove compatibility warning for LSC smart plug with BK7231N - #1750

Draft
WolfWildWeird wants to merge 17 commits into
esphome:mainfrom
WolfWildWeird:patch-1
Draft

Minor change - Remove compatibility warning for LSC smart plug with BK7231N#1750
WolfWildWeird wants to merge 17 commits into
esphome:mainfrom
WolfWildWeird:patch-1

Conversation

@WolfWildWeird

@WolfWildWeird WolfWildWeird commented Jul 29, 2026

Copy link
Copy Markdown

Brief description of the changes

  • Removed warning about ESPHome compatibility for LSC smart plug 2578685 based on BK7231N Microcontrollers.
  • Using new devices scripts format.
  • Integrate BK7231N and BK7231T in one config.yaml

Type of changes

  • New device (a single device only — one device per pull request)
  • Update existing device
  • Removing a device
  • General cleanup
  • Other

Checklist:

The rules below are enforced in CI by npm run validate-devices and npm run validate-yaml. The full reference is at Configuration YAML files.

  • Adding a new device adds a single device only — one device per pull request.
  • Each example yaml lives in its own .yaml file alongside index.md and is pulled into the page with a fenced block of the form ```yaml file=<name>.yaml — no inline yaml on added or modified pages.
  • The first file= fence on the page references config.yaml.
  • config.yaml is hardware-only: no top-level api:, ota:, mqtt:, web_server:, web_server_idf:, improv_serial:, captive_portal:, bluetooth_proxy:, or dashboard_import:, and no platform: homeassistant, platform: mqtt, or platform: template anywhere in the tree.
  • If config.yaml has a wifi: block, it contains only radio tunables (country, power_save_mode, output_power, …) — no ssid, password, networks, manual_ip, eap, or use_address. An empty ap: block is allowed.
  • No passwords (literal or !secret) on password:, *_password:, or psk: keys, and no !secret references anywhere in any example yaml.
  • For pages with made-for-esphome: true in frontmatter: at least one ```yaml url=… fence points at a .yaml file in the manufacturer's GitHub repo (github.com/<owner>/<repo>/(blob|raw)/<ref>/<path>.yaml or the raw.githubusercontent.com equivalent) so the rendered page shows the upstream config live.

Removed warning about compatibility with ESPHome for LSC smart plug 2578685.
@netlify

netlify Bot commented Jul 29, 2026

Copy link
Copy Markdown

Deploy Preview for esphome-devices ready!

Name Link
🔨 Latest commit b46f900
🔍 Latest deploy log https://app.netlify.com/projects/esphome-devices/deploys/6a6a43a29113920008e72b3b
😎 Deploy Preview https://deploy-preview-1750--esphome-devices.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
1 paths audited
Performance: 100 (no change from production)
Accessibility: 100 (no change from production)
Best Practices: 100 (no change from production)
SEO: 100 (no change from production)
PWA: -
View the detailed breakdown and full score reports
🤖 Make changes Run an agent on this branch

To edit notification comments on pull requests, go to your Netlify project configuration.

esphome[bot]
esphome Bot previously requested changes Jul 29, 2026

@esphome esphome Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

❌ Device configuration checks failed

The automated checks for the device pages in this pull request found 2 issues. Please address the items below and push an update — this review refreshes automatically and will be dismissed once the checks pass.

src/docs/devices/LSC-Plug-2578685/LSC-Plug-BK7231T.yaml

  • line 24 — invalid yaml: duplicated mapping key

src/docs/devices/LSC-Plug-2578685/index.md

  • line 46 — first yaml fence must reference config.yaml (saw LSC-Plug-BK7231T.yaml)

Need help? See the Adding Devices guide.

@esphome
esphome Bot marked this pull request as draft July 29, 2026 12:56
@esphome

esphome Bot commented Jul 29, 2026

Copy link
Copy Markdown
Contributor

Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍

Learn more about our pull request process.

Added configuration for LSC Plug BK7231N including WiFi, sensors, and relay control.
Updated the LSC Plug configuration to set a specific name and friendly name. Added status LED configuration and modified WiFi settings.
Add "yaml file" intégration format
Clean and check BK7231N YAML files to be more simple
Updated the fallback hotspot SSID for LSC Plug configuration.
Updated Wifi LSC Plug configuration.
Updated configuration instructions for BK7231T and BK7231N.
Removed unused logger, web_server, and captive_portal sections from the config. 🙄
Removed unnecessary line breaks in YAML code block.
@WolfWildWeird
WolfWildWeird marked this pull request as ready for review July 29, 2026 17:53
@esphome
esphome Bot dismissed their stale review July 29, 2026 17:53

Stale

@WolfWildWeird

Copy link
Copy Markdown
Author

Personal, public monologue (or Self Note)
Perhaps I should flip my approach to the new format...
Create a generic config.yaml and define the various boards in their respective configuration files...

esphome[bot]
esphome Bot previously requested changes Jul 29, 2026

@esphome esphome Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

❌ Device configuration checks failed

The automated checks for the device pages in this pull request found 2 issues. Please address the items below and push an update — this review refreshes automatically and will be dismissed once the checks pass.

`src/docs/devices/LSC-Plug-2578685/config.yaml````

  • unable to read: ENOENT: no such file or directory, open '/home/runner/work/devices.esphome.io/devices.esphome.io/src/docs/devices/LSC-Plug-2578685/config.yaml```'

src/docs/devices/LSC-Plug-2578685/index.md

  • line 46 — first yaml fence must reference config.yaml (saw `config.yaml````)

Need help? See the Adding Devices guide.

@esphome
esphome Bot marked this pull request as draft July 29, 2026 18:14
@esphome
esphome Bot dismissed their stale review July 29, 2026 18:21

Device configuration checks now pass — dismissing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant