Skip to content

Hiking DDS238-4-WiFi: update external component source - #1740

Open
kaboom748 wants to merge 2 commits into
esphome:mainfrom
kaboom748:main
Open

Hiking DDS238-4-WiFi: update external component source#1740
kaboom748 wants to merge 2 commits into
esphome:mainfrom
kaboom748:main

Conversation

@kaboom748

@kaboom748 kaboom748 commented Jul 27, 2026

Copy link
Copy Markdown

Brief description of the changes

The dxs238xw component on this page pointed at rodgon81/esphome, which uses schema
helpers removed in ESPHome 2025.11 (NUMBER_SCHEMA, BUTTON_SCHEMA, …). It no longer
compiles on current releases, so the instructions on this page were broken for anyone
with an up-to-date install.

This points the external_components block at a fork with the deprecated schemas
migrated. Tested on real hardware (DDS238-4 W).

The page's three main yaml configs have also been moved into sibling .yaml files, as
required for modified pages; the small illustrative snippets are marked inline.

Type of changes

  • New device (a single device only — one device per pull request)
  • Update existing device
  • Removing a device
  • General cleanup
  • Other

Checklist:

The rules below are enforced in CI by npm run validate-devices and npm run validate-yaml. The full reference is at Configuration YAML files.

  • Adding a new device adds a single device only — one device per pull request.
  • Each example yaml lives in its own .yaml file alongside index.md and is pulled into the page with a fenced block of the form ```yaml file=<name>.yaml — no inline yaml on added or modified pages.
  • The first file= fence on the page references config.yaml.
  • config.yaml is hardware-only: no top-level api:, ota:, mqtt:, web_server:, web_server_idf:, improv_serial:, captive_portal:, bluetooth_proxy:, or dashboard_import:, and no platform: homeassistant, platform: mqtt, or platform: template anywhere in the tree.
  • If config.yaml has a wifi: block, it contains only radio tunables (country, power_save_mode, output_power, …) — no ssid, password, networks, manual_ip, eap, or use_address. An empty ap: block is allowed.
  • No passwords (literal or !secret) on password:, *_password:, or psk: keys, and no !secret references anywhere in any example yaml.
  • For pages with made-for-esphome: true in frontmatter: at least one ```yaml url=… fence points at a .yaml file in the manufacturer's GitHub repo (github.com/<owner>/<repo>/(blob|raw)/<ref>/<path>.yaml or the raw.githubusercontent.com equivalent) so the rendered page shows the upstream config live.

@netlify

netlify Bot commented Jul 27, 2026

Copy link
Copy Markdown

Deploy Preview for esphome-devices ready!

Name Link
🔨 Latest commit ea1d534
🔍 Latest deploy log https://app.netlify.com/projects/esphome-devices/deploys/6a67a35ff5fe5e000739c989
😎 Deploy Preview https://deploy-preview-1740--esphome-devices.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
1 paths audited
Performance: 100 (no change from production)
Accessibility: 100 (no change from production)
Best Practices: 100 (no change from production)
SEO: 100 (no change from production)
PWA: -
View the detailed breakdown and full score reports
🤖 Make changes Run an agent on this branch

To edit notification comments on pull requests, go to your Netlify project configuration.

esphome[bot]
esphome Bot previously requested changes Jul 27, 2026

@esphome esphome Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

❌ Device configuration checks failed

The automated checks for the device pages in this pull request found 12 issues. Please address the items below and push an update — this review refreshes automatically and will be dismissed once the checks pass.

src/docs/devices/Hiking-DDS238-4-WiFi/index.md


Need help? See the Adding Devices guide.

@esphome
esphome Bot marked this pull request as draft July 27, 2026 13:52
@esphome

esphome Bot commented Jul 27, 2026

Copy link
Copy Markdown
Contributor

Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍

Learn more about our pull request process.

@kaboom748

Copy link
Copy Markdown
Author

https://github.com/kaboom748/dxs238xw

Solved: external module working July 2026

@kaboom748 kaboom748 changed the title Working External Module in July 2026 Hiking DDS238-4-WiFi: update external component source Jul 27, 2026
@esphome
esphome Bot dismissed their stale review July 27, 2026 18:36

Device configuration checks now pass — dismissing.

@kaboom748
kaboom748 marked this pull request as ready for review July 27, 2026 18:37
@kaboom748

Copy link
Copy Markdown
Author

Updated: the page now builds, and the yaml configs are moved into sibling files as required.

I have the hardware (DDS238-4 W) and I'm glad to run tests on request, though I don't have
the bandwidth to take on further code changes myself. If anyone wants to pick up the
component and upstream it properly, the fork is a working starting point.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant