-
-
Notifications
You must be signed in to change notification settings - Fork 72
Integrate Home Assistant data table with enhanced UI features #756
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Major Features: - Add table view with HA-style data table implementation - Enhanced card view with status badges and IP/mDNS information display - Sorting and filtering functionality for both views - Persistent user preferences (view mode, sort, filter settings) - Mobile responsive controls and overflow menus UI/UX Improvements: - Consistent status indicators with proper colors (online/offline/discovered) - Clean status badges without background colors as requested - Proper mDNS hostname display and formatting - Fixed z-index layering issues between dropdowns and action buttons - Improved icon colors in action menus (both light and dark modes) - Consolidated styling architecture in respective components Technical Enhancements: - Device IP resolution API integration with 30-second refresh intervals - Proper component separation (styles moved to correct components) - Enhanced CSS specificity for icon color overrides - Fixed TypeScript compilation errors and code formatting - Improved error handling and graceful fallbacks Bug Fixes: - Fixed duplicate status indicators in card view - Resolved status indicator visibility in table view - Fixed action menu icon colors in both views - Corrected web visit URL formatting for mDNS hostnames - Fixed sorting functionality in table view - Resolved filter functionality issues - Fixed z-index conflicts between UI elements
- Use device configuration filename (without .yaml/.yml extension) for mDNS construction - Maintains fallback to device.address if it ends with .local - Fixes both card view and table view displays
Let's pull in the data table like how HACS does it, with a git submodule: https://github.com/hacs/frontend Could you also include screenshots? Here is a mockup that we've been working on based on the data table. Could you make it look like this? |
Waiting on PR on esphome esphome/esphome#9006 |
Yes - give me a little bit. |
Any reason we would want to show the IP address and not just show the mdns name? (as-in, do we need that new API?) |
Agreed, not sure we even need the mdns name as its in the config. |
|
Yes, but the dashboard is not the place if you are writing a config that has the suffix enabled. The dashboard works on one YAML per one device only |
I think i would prefer seeing the mDNS name more then the configurated name. Would it be an idea to add it to a list of none visible column's and the user could select which column is being shown. Like HACS has. Anyway a good Job @brayStorm. |
@brayStorm Just wanted to check in on this one. Happy to help move this forward. |
Properly adding the submodule is proving very challenging |
I spent a few hours exploring that, and while I got it working, we end up with a 785k index.js from all the deps that HA has. It was quite noticeable. I think the maint burden of keeping up with all of HA's deps will exceed the value so it likely makes sense to vendor it here instead. https://github.com/esphome/dashboard/tree/ha_data_table_submodule |
Tried to make it a bit more like the mock up above. Getting the zindex to work with the expansion menu is difficult |
Not sure if this is the right place, but having another table (as per the mockup) to edit packages/includes would be amazing. |
Summary
Key Features
Technical Implementation
esphome-data-table
component following HA design patternsTest Plan