-
-
Notifications
You must be signed in to change notification settings - Fork 76
Limit parallel release jobs to 5 at once #1213
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
CodSpeed Performance ReportMerging #1213 will not alter performanceComparing Summary
|
We might also consider dropping Python 3.9 and 3.10. We can probably drop armv7l wheels as well in 6 months |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1213 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 20 20
Lines 2935 2935
=========================================
Hits 2935 2935 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
WalkthroughThe release workflow configuration for GitHub Actions was updated to limit the maximum number of parallel jobs in the wheel-building step to five, by setting Changes
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Nitpick comments (1)
.github/workflows/release.yml (1)
15-15
: Optional: addfail-fast: false
By default, GitHub cancels in-flight matrix jobs when one fails. If you’d like to collect logs and artifacts from all OS/Python combinations even on failures, consider disabling fail-fast:strategy: max-parallel: 5 fail-fast: false matrix: …
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
.github/workflows/release.yml
(1 hunks)
🔇 Additional comments (1)
.github/workflows/release.yml (1)
15-15
: Throttle concurrent jobs
Addingmax-parallel: 5
correctly limits wheel build concurrency to five runners, which aligns with the PR objective of reducing resource contention during releases.
What does this implement/fix?
One release of aioesphomeapi takes up 12 / 20 of ESPHomes action runners at a time.
If we can wait a little longer for the release to be finished, this allows other jobs in the org to run.
Types of changes
Related issue or feature (if applicable):
Pull request in esphome (if applicable):
Checklist:
tests/
folder).