Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Additional improvements to CI workflow #750

Merged
merged 1 commit into from
Feb 7, 2025

Conversation

jessebraham
Copy link
Member

This has pretty drastically reduced the runtime on my fork at least. Some additional re-org in here too, sorry for the noise.

Additional considerations:

  • The matrices in the check, check-lib, and msrv jobs are different
    • Should we check all platforms/archs for each of these jobs, or is a limited subset adequate?
    • If the latter, which platforms should be checked? Is x86_64 macOS/Linux/Windows enough for the check-lib and msrv jobs? Something else?

@jessebraham jessebraham added the skip-changelog Skips the changelog CI check label Feb 7, 2025
@jessebraham
Copy link
Member Author

Guess we need to update the merge queue settings prior to merging this, was a little confused why it was waiting for jobs which don't exist for a minute there 😅

@SergioGasquez
Copy link
Member

Should we check all platforms/archs for each of these jobs, or is a limited subset adequate?

I think we should be good with current tests! If not, we can revert this situation in the future

Copy link
Member

@SergioGasquez SergioGasquez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks

@SergioGasquez SergioGasquez added this pull request to the merge queue Feb 7, 2025
Merged via the queue into esp-rs:main with commit c73ea4d Feb 7, 2025
25 checks passed
@jessebraham jessebraham deleted the fixes/ci branch February 7, 2025 15:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
skip-changelog Skips the changelog CI check
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants