Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add rustfmt.toml and format packages #744

Merged
merged 3 commits into from
Feb 5, 2025

Conversation

jessebraham
Copy link
Member

Bit of a gross PR, but I've been wanting to do this for awhile, so let's just rip off the band-aid and be done with it 😅

(Sorry to anybody with open PRs 😂)

@jessebraham jessebraham added the skip-changelog Skips the changelog CI check label Feb 5, 2025
ChecksumMd5Args, CompletionsArgs, ConnectArgs, EraseFlashArgs, EraseRegionArgs,
EspflashProgress, FlashConfigArgs, MonitorArgs, PartitionTableArgs, ReadFlashArgs,
},
cli::{self, config::Config, monitor::monitor, *},
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Normally I'd like to avoid glob imports, but in this case I think it's justified

Copy link
Member

@SergioGasquez SergioGasquez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks

@SergioGasquez SergioGasquez added this pull request to the merge queue Feb 5, 2025
Merged via the queue into esp-rs:main with commit aab2ad4 Feb 5, 2025
29 checks passed
@jessebraham jessebraham deleted the fixes/rustfmt branch February 5, 2025 16:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
skip-changelog Skips the changelog CI check
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants