Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Initial support for P4 #533

Merged
merged 3 commits into from
Jan 9, 2024
Merged

Initial support for P4 #533

merged 3 commits into from
Jan 9, 2024

Conversation

SergioGasquez
Copy link
Member

@SergioGasquez SergioGasquez commented Dec 20, 2023 •
edited
Loading

There are still a few TODOs to resolve but we match the state of P4 in esptool.

@georgik did some testing and was able to flash and monitor:

espflash flash --no-stub build/hello_world.elf --monitor
...
I (414) main_task: Calling app_main()
Hello world!
This is esp32p4 chip with 2 CPU core(s), , silicon revision v0.0, 4MB external flash
Minimum free heap size: 618808 bytes

@SergioGasquez SergioGasquez linked an issue Dec 20, 2023 that may be closed by this pull request
Add support for the ESP32-P4 #531
Closed
@SergioGasquez SergioGasquez marked this pull request as ready for review January 9, 2024 17:49
jessebraham
jessebraham approved these changes Jan 9, 2024
View reviewed changes
Copy link
Member

@jessebraham jessebraham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@jessebraham jessebraham merged commit b427b2b into esp-rs:main Jan 9, 2024
19 checks passed
@SergioGasquez SergioGasquez deleted the feat/esp32p4 branch January 10, 2024 08:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jessebraham jessebraham jessebraham approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add support for the ESP32-P4
2 participants
@SergioGasquez @jessebraham