-
Notifications
You must be signed in to change notification settings - Fork 23
support esp-mbedtls for esp32c6 #69
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Even if the long term goal would be to have per-target support instead of per-chip, it would be really nice to have this one merged in the meantime :) |
@AnthonyGrondin from your POV, is this complete, up to date and ready for merge? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This would need to rebase on top of the current head (which now builds the libs for us 🙂)
Then after I could test it locally to ensure everything works well.
The following can be removed because it's the default now:
#[cfg(feature = "esp32c6")]
controller
.set_power_saving(esp_wifi::config::PowerSaveMode::None)
.unwrap();
|
||
set(CMAKE_AR "${CLANG_DIR_PATH}/llvm-ar") | ||
set(CMAKE_RANLIB "${CLANG_DIR_PATH}/llvm-ranlib") | ||
set(CMAKE_OBJDUMP xtensa-esp32s3-elf-objdump) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Copy error, this needs to be updated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @AnthonyGrondin, I updated it and others also.
@AnthonyGrondin It seems we got issue with the CI build for the libs. Could you take a look at this ? I'm not an expert about it |
That's a edge-case I forgot to handle in my initial implementation. Please include this commit to fix it: |
… LLVM extended installation
Works well, Thanks @AnthonyGrondin |
Thanks everyone for making this happen! |
this PR is to support for esp32c6.
related issue: #56