Skip to content

support esp-mbedtls for esp32c6 #69

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 10 commits into
base: main
Choose a base branch
from
Open

Conversation

TuEmb
Copy link

@TuEmb TuEmb commented Jan 23, 2025

this PR is to support for esp32c6.

related issue: #56

@kalkyl
Copy link

kalkyl commented Jul 9, 2025

Even if the long term goal would be to have per-target support instead of per-chip, it would be really nice to have this one merged in the meantime :)

@ivmarkov
Copy link
Collaborator

ivmarkov commented Jul 9, 2025

@AnthonyGrondin from your POV, is this complete, up to date and ready for merge?

Copy link
Collaborator

@AnthonyGrondin AnthonyGrondin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This would need to rebase on top of the current head (which now builds the libs for us 🙂)

Then after I could test it locally to ensure everything works well.

The following can be removed because it's the default now:

#[cfg(feature = "esp32c6")]
    controller
        .set_power_saving(esp_wifi::config::PowerSaveMode::None)
        .unwrap();


set(CMAKE_AR "${CLANG_DIR_PATH}/llvm-ar")
set(CMAKE_RANLIB "${CLANG_DIR_PATH}/llvm-ranlib")
set(CMAKE_OBJDUMP xtensa-esp32s3-elf-objdump)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy error, this needs to be updated

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @AnthonyGrondin, I updated it and others also.

@TuEmb TuEmb force-pushed the esp32c6_support branch from a816e1d to c24c465 Compare July 10, 2025 02:13
@TuEmb
Copy link
Author

TuEmb commented Jul 10, 2025

@AnthonyGrondin It seems we got issue with the CI build for the libs. Could you take a look at this ? I'm not an expert about it

@AnthonyGrondin
Copy link
Collaborator

@AnthonyGrondin It seems we got issue with the CI build for the libs. Could you take a look at this ? I'm not an expert about it

That's a edge-case I forgot to handle in my initial implementation.

Please include this commit to fix it:
f8fd68e

@TuEmb
Copy link
Author

TuEmb commented Jul 11, 2025

@AnthonyGrondin It seems we got issue with the CI build for the libs. Could you take a look at this ? I'm not an expert about it

That's a edge-case I forgot to handle in my initial implementation.

Please include this commit to fix it: f8fd68e

Works well, Thanks @AnthonyGrondin

@kalkyl
Copy link

kalkyl commented Jul 11, 2025

Thanks everyone for making this happen!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants