RGB Interfaced bindings for targets with SOC_LCD_RGB_SUPPORTED #368
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Vollbrecht
requested changes
Feb 12, 2025
There was a problem hiding this comment.
this headers were defiantly removed at one point in time from a 5.3 release. Did they back-port it upstream again?
In general this imports are not target specific, so please provide upstream evidence that they are still part of the specific esp-idf versions or where reintroduced
|
As far as I can tell they where never removed just moved to a new folder in commit ad84b61 , but I could be mistaken |
|
Ok, so it seams it is at least part of all current released versions. It seams they have a added soc capability flag specifically for "SOC_LCD_RGB_SUPPORTED". So instead of hard coding the s3 as supported we can use that flag instead in the header file( i think the p4 will also have the feature etc) |
joriskleiber
force-pushed
the
fix-rgb-interface-bindings
branch
from
a7793bc to
b40ace3
Compare
joriskleiber
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thank you for your contribution!
We appreciate the time and effort you've put into this pull request.
To help us review it efficiently, please ensure you've gone through the following checklist:
Submission Checklist 📝
cargo fmtcommand to ensure that all changed code is formatted correctly.cargo clippycommand to ensure that all changed code passes latest Clippy nightly lints.CHANGELOG.mdin the proper section.Pull Request Details 📖
Description
ESP-IDF kept supporting the RGB Interface for the ESP32-S3 after 5.3, I don't know if this is an error on the ESP-IDF side but for now I re-enabled the bindings generation for the ESP32-S3.
https://docs.espressif.com/projects/esp-idf/en/stable/esp32s3/api-reference/peripherals/lcd/rgb_lcd.html