Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI optimizations #3129

Merged
merged 6 commits into from
Feb 13, 2025
Merged

CI optimizations #3129

merged 6 commits into from
Feb 13, 2025

Conversation

bjoernQ
Copy link
Contributor

@bjoernQ bjoernQ commented Feb 11, 2025

Thank you for your contribution!

We appreciate the time and effort you've put into this pull request.
To help us review it efficiently, please ensure you've gone through the following checklist:

Submission Checklist 📝

  • I have updated existing examples or added new ones (if applicable).
  • I have used cargo xtask fmt-packages command to ensure that all changed code is formatted correctly.
  • My changes were added to the CHANGELOG.md in the proper section.
  • I have added necessary changes to user code to the Migration Guide.
  • My changes are in accordance to the esp-rs API guidelines

Extra:

Pull Request Details 📖

Description

This gets CI build times down a little bit - not what I was hoping for but at least something

This PR

image

Some other randomly picked PR

image

Partially addresses #3069 (this is just the YAML ported to the xtask - missing the part about "enforce full MSRV checks")

Testing

Compare the build times here with another recent branch

@bjoernQ bjoernQ marked this pull request as ready for review February 11, 2025 16:44
@bjoernQ bjoernQ changed the title test Small CI optimizations Feb 11, 2025
@bjoernQ bjoernQ marked this pull request as draft February 12, 2025 10:26
@bjoernQ bjoernQ force-pushed the another-ci-experiment branch from 4addb23 to 64cca00 Compare February 12, 2025 13:04
@bjoernQ bjoernQ added the skip-changelog No changelog modification needed label Feb 12, 2025
@bjoernQ bjoernQ force-pushed the another-ci-experiment branch from 6b1f39d to 7b66a09 Compare February 12, 2025 14:31
@bjoernQ bjoernQ marked this pull request as ready for review February 12, 2025 14:46
@bjoernQ bjoernQ force-pushed the another-ci-experiment branch from 7b66a09 to 411c7bc Compare February 13, 2025 10:07
@bjoernQ
Copy link
Contributor Author

bjoernQ commented Feb 13, 2025

the documentation changes had quite a performance hit but this is still faster than it was before

@bjoernQ bjoernQ changed the title Small CI optimizations CI optimizations Feb 13, 2025
Copy link
Member

@MabezDev MabezDev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

16m -> 11m for the longest job is quite a nice improvement (31~%), LGTM!

Copy link
Member

@SergioGasquez SergioGasquez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks, only one idea that can be ignored

xtask/src/main.rs Outdated Show resolved Hide resolved
@bjoernQ bjoernQ force-pushed the another-ci-experiment branch from 92a1e3f to 186df38 Compare February 13, 2025 13:00
@bjoernQ bjoernQ added this pull request to the merge queue Feb 13, 2025
Merged via the queue into esp-rs:main with commit 68c660f Feb 13, 2025
27 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
skip-changelog No changelog modification needed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants