Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TESTING SCCACHE #3128

Closed
wants to merge 1 commit into from
Closed

TESTING SCCACHE #3128

wants to merge 1 commit into from

Conversation

bjoernQ
Copy link
Contributor

@bjoernQ bjoernQ commented Feb 11, 2025

Thank you for your contribution!

We appreciate the time and effort you've put into this pull request.
To help us review it efficiently, please ensure you've gone through the following checklist:

Submission Checklist 📝

  • I have updated existing examples or added new ones (if applicable).
  • I have used cargo xtask fmt-packages command to ensure that all changed code is formatted correctly.
  • My changes were added to the CHANGELOG.md in the proper section.
  • I have added necessary changes to user code to the Migration Guide.
  • My changes are in accordance to the esp-rs API guidelines

Extra:

Pull Request Details 📖

Description

Please provide a clear and concise description of your changes, including the motivation behind these changes. The context is crucial for the reviewers.

Testing

Describe how you tested your changes.

@MabezDev
Copy link
Member

We might need to clear the current caches to "make room" for the sscache stuff? iirc the last time I looked at the runner caches they were full.

@@ -78,6 +80,9 @@ jobs:
toolchain: stable
components: rust-src

- name: Run sccache-cache
uses: mozilla-actions/[email protected]

- uses: Swatinem/rust-cache@v2
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we need both sccache-cache and rust-cache?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we don't need sccache at all since it doesn't give any benefits in our setup (will write another comment why) - and I'm not sure if we really benefit from rust-cache as is either

@bjoernQ
Copy link
Contributor Author

bjoernQ commented Feb 11, 2025

so ..... sccache won't cache (well it caches but won't hit the cache) if there is a crate with a dependency on any proc-macro-crate (probably transitive)

I guess it makes sense since a proc-macro could do anything but even something like the document-features crate will make sccache ineffective (and we use a lot of proc-macros and so do all the heavier crates we use)

closing this experiment - maybe will do another experiment however

@bjoernQ bjoernQ closed this Feb 11, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants