Fix nightly CI errors #3123
Merged
Fix nightly CI errors #3123
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #3092
Successful run: https://github.com/jessebraham/esp-hal/actions/runs/13237219830
There were a couple lint errors that I just allowed, wasn't sure how to resolve them easily and didn't want to accidentally break anything while trying.
Also updated the workflow not to comment on the issue if one is already open. I think either having an issue open or not is fine, the presence of the issue indicates there are problems to resolve and we don't need to spam it incessantly.