Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DO NOT MERGE: polishing experiments #3117

Draft
wants to merge 3 commits into
base: main
Choose a base branch
from
Draft

Conversation

MabezDev
Copy link
Member

@MabezDev MabezDev commented Feb 7, 2025

I suggest bulding and viewing the docs locally, then reviewing this commit by commit. The intention is not to merge this, but choose what we want from it and I'll PR them seperately.

  • Commit 1 should be fairly uncontroversial I think. I don't think the split API is fully ready yet, and we may want to experiment more here.
  • Commit 2 replaces write|read_bytes with just write|read when the input parameter is a byte slice. Imo this is fine, and there is precidence in the std (e.g https://doc.rust-lang.org/std/fs/fn.write.html only accepts bytes)(and other crates in the embedded ecosystem for this)
  • Commit three shuffles some things around to firstly show stable items for uart, then unstable, to complete this I would apply this to all partially stable drivers.

Comments appreciated.

@MabezDev MabezDev added the skip-changelog No changelog modification needed label Feb 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
skip-changelog No changelog modification needed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant