More validation and # Errors entries
#3074
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bugadani
reviewed
Jan 30, 2025
playfulFence
force-pushed
the
upd/wtbeta
branch
2 times, most recently
from
f76e5ef to
48d1182
Compare
MabezDev
requested changes
Feb 4, 2025
There was a problem hiding this comment.
Not sure if you're looking for review feedback now, but I guess you're gunna get it :D.
In general the approach looks sound. I think that we should document the specific variants that can be returned (this should be possible with rustdoc). We should probably mark the tolerance bits as unstable for now, just so we can give it some time to soak in. Finally, tests plz :D.
playfulFence
force-pushed
the
upd/wtbeta
branch
from
eb58aff to
b617592
Compare
bjoernQ
reviewed
Feb 6, 2025
bjoernQ
reviewed
Feb 6, 2025
bjoernQ
reviewed
Feb 6, 2025
bjoernQ
reviewed
Feb 6, 2025
bjoernQ
reviewed
Feb 6, 2025
jessebraham
reviewed
Feb 6, 2025
jessebraham
reviewed
Feb 6, 2025
playfulFence
force-pushed
the
upd/wtbeta
branch
from
61bfe35 to
440cadc
Compare
SergioGasquez
approved these changes
Feb 6, 2025
playfulFence
force-pushed
the
upd/wtbeta
branch
from
440cadc to
1f078db
Compare
playfulFence
force-pushed
the
upd/wtbeta
branch
from
1f078db to
c1e6ab6
Compare
MabezDev
requested changes
Feb 6, 2025
unstable: macro -> feat
playfulFence
force-pushed
the
upd/wtbeta
branch
from
053c5ce to
c361e94
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introduces more validation for SPI and UART, allows setting baudrate tolerance for UART config, adds more
# Errorsentriescloses #2839