Use self-hosted mac mini for the small, auxiliary tasks #3072
+30
−26
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bugadani
force-pushed
the
self-hosted
branch
5 times, most recently
from
c6332b1 to
ed32f6d
Compare
bugadani
changed the title
MabezDev
reviewed
Jan 31, 2025
| - uses: dtolnay/rust-toolchain@v1 | ||
| with: | ||
| target: riscv32imc-unknown-none-elf,riscv32imac-unknown-none-elf | ||
| toolchain: ${{ env.MSRV }} | ||
| components: rust-src | ||
| - name: install esp toolchain |
There was a problem hiding this comment.
Shall we wait for the xtensa toolchain action to be updated before merging with this?
There was a problem hiding this comment.
Let's, this is a bit of an eyesore
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Total CPU time goes down by 13 or so minutes (https://github.com/esp-rs/esp-hal/actions/runs/13074331617/usage, https://github.com/esp-rs/esp-hal/actions/runs/13074331619/usage versus https://github.com/esp-rs/esp-hal/actions/runs/13073580566/usage, https://github.com/esp-rs/esp-hal/actions/runs/13073580561/usage). We use a few less GH runners, which hopefully means we can check more PRs in parallel now, but there is no meaningful difference in the max runtime because the bottleneck is still the bunch of linting and building for the S3 - chip-specific CI jobs still run on the github-hosted runners.
cc #3065 - though we can probably do better somehow.