-
Notifications
You must be signed in to change notification settings - Fork 244
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
bump rand_core version to 0.9.0 #3046
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I guess this deserves a mention in the migration guide.
We shouldn't unconditionally pull in <1.0 dependencies, even if the RNG itself is unstable. |
What do you mean by this? This dependency was already included, they've just updated the version, and there are like a dozen other dependencies which are <1.0 and not behind a feature. |
|
I have added an entry to the MIGRATING-0.23.md document. Also just to clarify a bit, the removal of esp-hal's |
Thank you for your contribution!
We appreciate the time and effort you've put into this pull request.
To help us review it efficiently, please ensure you've gone through the following checklist:
Submission Checklist 📝
cargo xtask fmt-packages
command to ensure that all changed code is formatted correctly.CHANGELOG.md
in the proper section.Extra:
Pull Request Details 📖
Description
Please provide a clear and concise description of your changes, including the motivation behind these changes. The context is crucial for the reviewers.
These changes are to support the latest version of rand_core's
RngCore
trait, wheretry_fill_bytes
has been moved to theTryRngCore
trait.Testing
Describe how you tested your changes.
Tested by running wifi examples where a u64 seed is generated via RngCore::next_u64 on a esp32-c6 devkit.