Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Peripheral drivers should validate configuration before applying it to hardware #2839

Closed
bugadani opened this issue Dec 19, 2024 · 2 comments · Fixed by #3074
Closed

Peripheral drivers should validate configuration before applying it to hardware #2839

bugadani opened this issue Dec 19, 2024 · 2 comments · Fixed by #3074
Assignees
@playfulFence
Labels
beta-blocker bug Something isn't working
Milestone
1.0.0-beta.0

Comments

@bugadani
Copy link
Contributor

bugadani commented Dec 19, 2024 •
edited
Loading

apply_config is fallible, which means two things:

  • It can fail
  • The user can ignore the failure and keep using the driver

Because of this, we should validate the whole configuration before we apply it to the hardware. I don't consider this a blocking issue, although we might want to get it right before the release.
@bugadani bugadani added bug Something isn't working status:needs-attention This should be prioritized labels Dec 19, 2024
@bugadani bugadani mentioned this issue Dec 19, 2024
Merged
@playfulFence playfulFence mentioned this issue Dec 20, 2024
Merged
@bjoernQ bjoernQ removed the status:needs-attention This should be prioritized label Jan 6, 2025
@playfulFence
Copy link
Contributor

When this issue is resolved, we must not forget to add the appropriate # Errors entries (see related FIXMEs in this PR).

@playfulFence playfulFence self-assigned this Jan 27, 2025
@MabezDev MabezDev added this to the 1.0.0-beta.0 milestone Jan 27, 2025
@MabezDev
Copy link
Member

On further reflection, and a push from @playfulFence I think this is indeed something we want to get it sooner rather than later, for example we can set the baud to a billion bps, and apply_config will happily try to do it.

@playfulFence playfulFence mentioned this issue Jan 30, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@playfulFence playfulFence

Labels
beta-blocker bug Something isn't working
Projects
esp-rs
Archived in project
Milestone
1.0.0-beta.0
Development

Successfully merging a pull request may close this issue.

More validation and # Errors entries playfulFence/esp-hal
4 participants
@bugadani @bjoernQ @MabezDev @playfulFence