-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support ELIF
(else-if) in templates
#96
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ideally we would add a test case for ELIF - otherwise looks fine
Do we have tests to add it to? |
Not a lot of them but especially for the IF/ELSE/ENDIF stuff: Lines 578 to 728 in de38c80
There is probably more we could test ofc |
Certainly easier to test this than eyeballing the generated code, thanks. Back to fixing, I go :D |
This PR adds support for else-if in templates, which will be useful if we are going to have more options that are mutually exclusive.
The PR also reorders log setup to before HAL initialization, so that the HAL's init process may be able to print logs if such configured.