Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add an xtask package to simplify our CI workflow #22

Merged
merged 7 commits into from
Oct 25, 2024

Conversation

jessebraham
Copy link
Member

This turned out to be a bit bigger of a project than anticipated, but this PR should close 4 issues so that's a win at least 😁

The output of the checks are a bit noisy, maybe we want to avoid displaying stdout and stderr to make the logs a bit more readable?

I've also just copied the combinations of features from the existing workflow, perhaps we want to check more?

Happy to make any changes, lemme know what you guys think.

Copy link
Member

@SergioGasquez SergioGasquez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks for fixing/improving so many things!

Current CI takes about 14 mins, we may want to check all the combinations for every chip, but that will increase the CI time. Maybe run it daily instead of running it per commit? This would catch issue like #19 #20

README.md Outdated Show resolved Hide resolved
@MabezDev
Copy link
Member

Current CI takes about 14 mins

Unlike esp-hal, I see this repo getting less and less activity as it stabilizes. Imo CI time is less of a concern here, but I'll leave it with you guys for the final call.

@bjoernQ
Copy link
Collaborator

bjoernQ commented Oct 25, 2024

Current CI takes about 14 mins

Unlike esp-hal, I see this repo getting less and less activity as it stabilizes. Imo CI time is less of a concern here, but I'll leave it with you guys for the final call.

Wanted to write the same comment - if this assumption turns out to be wrong,, we can reconsider it

Copy link
Collaborator

@bjoernQ bjoernQ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@jessebraham jessebraham merged commit 5f285d1 into esp-rs:main Oct 25, 2024
8 checks passed
@jessebraham jessebraham deleted the feature/xtask branch October 25, 2024 12:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
4 participants