-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add an xtask
package to simplify our CI workflow
#22
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Unlike esp-hal, I see this repo getting less and less activity as it stabilizes. Imo CI time is less of a concern here, but I'll leave it with you guys for the final call. |
Wanted to write the same comment - if this assumption turns out to be wrong,, we can reconsider it |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
This turned out to be a bit bigger of a project than anticipated, but this PR should close 4 issues so that's a win at least 😁
--output-path
option so that we can generate the projects in arbitrary directoriesxtask
can generate projects in temporary directories, to avoid polluting the workspace when run locallystack-protector
options (closes Remove stack-protection #16)xtask
package to simplify our CI workflow (closes Add support forxtask
to simplify checks #11)xtask
package and run unit tests (closes CI: Run unit tests #13)async_main.rs
(should close Generated code leads to runtime panic #21)The output of the checks are a bit noisy, maybe we want to avoid displaying
stdout
andstderr
to make the logs a bit more readable?I've also just copied the combinations of features from the existing workflow, perhaps we want to check more?
Happy to make any changes, lemme know what you guys think.