Add a switch to enable unstable esp-hal features #104
Conversation
|
|
bugadani
force-pushed
the
unstable
branch
3 times, most recently
from
6a82959 to
a788161
Compare
| name: unstable-hal | ||
| display_name: Enable unstable HAL features. | ||
| help: esp-hal contains many unstable features that are not yet ready for general use. This configuration enables using them. | ||
|
|
||
| - !Option | ||
| name: alloc |
There was a problem hiding this comment.
should esp-alloc require unstable? (I guess yes)
There was a problem hiding this comment.
The tests passed, so why?
I think the separate "unstable-dependencies" we had is unnecessary noise, people can decide if they want a dependency or not.
There was a problem hiding this comment.
I think the separate "unstable-dependencies" we had is unnecessary noise
I agree just the linked issue still says otherwise
There was a problem hiding this comment.
Do you want me to call out for each 0.x dependency that they are unstable?
There was a problem hiding this comment.
I personally don't want that at all- but
Crates like esp-println, esp-backtrace whilst powerful, I don't think are ready for stabilization yet and should be opt in.
reads to me like that was the idea
There was a problem hiding this comment.
Ah, right, I planned to make them opt-in in an upcoming PR. Updated the description to not close that issue yet.
Probably closes #84