Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deduplicate redundant "All options" #102

Merged
merged 3 commits into from
Feb 11, 2025
Merged

Deduplicate redundant "All options" #102

merged 3 commits into from
Feb 11, 2025

Conversation

bugadani
Copy link
Contributor

@bugadani bugadani commented Feb 10, 2025 •
edited
Loading

Before this PR we were testing the same combination several times.

[2025-02-10T15:17:48Z INFO  xtask] ["alloc", "probe-rs"]
[2025-02-10T15:17:48Z INFO  xtask] ["alloc", "probe-rs"]
[2025-02-10T15:17:48Z INFO  xtask] ["alloc", "probe-rs", "wifi"]
[2025-02-10T15:17:48Z INFO  xtask] ["alloc", "probe-rs", "wifi"]
[2025-02-10T15:17:48Z INFO  xtask] ["alloc", "alloc", "probe-rs", "wifi"]
[2025-02-10T15:17:48Z INFO  xtask] ["alloc", "alloc", "probe-rs", "wifi"]

This PR hopefully cuts down the CI time a bit. We also seem to support wifi && ble at least in some places in the templates, so I've removed the filter for them.

The PR also removes the push trigger because for some reason, everything ran twice on each PR.

@bugadani bugadani added the skip-changelog No changelog modification needed label Feb 10, 2025
@bugadani bugadani changed the title All options Deduplicate redundant "All options" Feb 10, 2025
@bugadani bugadani force-pushed the all-options branch 6 times, most recently from eb21dd5 to b70acd9 Compare February 10, 2025 15:59
bjoernQ
bjoernQ approved these changes Feb 11, 2025
View reviewed changes
Copy link
Collaborator

@bjoernQ bjoernQ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@bjoernQ bjoernQ added this pull request to the merge queue Feb 11, 2025
Merged via the queue into main with commit b6a8c8e Feb 11, 2025
10 checks passed
@SergioGasquez SergioGasquez deleted the all-options branch February 11, 2025 08:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bjoernQ bjoernQ bjoernQ approved these changes

Assignees
No one assigned
Labels
skip-changelog No changelog modification needed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bugadani @bjoernQ