Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use current dependencies #10

Merged
merged 3 commits into from
Oct 11, 2024
Merged

Use current dependencies #10

merged 3 commits into from
Oct 11, 2024

Conversation

bjoernQ
Copy link
Collaborator

@bjoernQ bjoernQ commented Oct 11, 2024

  • use current HAL and other dependencies
  • add a .vscode/settings.json
  • some simplification of the template because we now support expressions as conditions

@bjoernQ bjoernQ requested a review from SergioGasquez October 11, 2024 12:42
SergioGasquez
SergioGasquez approved these changes Oct 11, 2024
View reviewed changes
Copy link
Member

@SergioGasquez SergioGasquez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Only one small nitpick that can be ignored

template/rust-toolchain.toml Outdated Show resolved Hide resolved
@bjoernQ
Copy link
Collaborator Author

bjoernQ commented Oct 11, 2024

We probably also should run unit tests in CI (now that we have them) but I'm not good at CI stuff

@bjoernQ bjoernQ merged commit e52cd03 into main Oct 11, 2024
94 checks passed
@bjoernQ bjoernQ deleted the use-current-dependencies branch October 11, 2024 14:24
@SergioGasquez SergioGasquez mentioned this pull request Oct 15, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SergioGasquez SergioGasquez SergioGasquez approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bjoernQ @SergioGasquez