Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix broken url of esp-hal example #151

Merged
merged 4 commits into from
Mar 22, 2024
Merged

Fix broken url of esp-hal example #151

merged 4 commits into from
Mar 22, 2024

Conversation

HaoboGu
Copy link
Contributor

@HaoboGu HaoboGu commented Mar 21, 2024

example folder under each SOC's folder was moved to examples, the url pointed to esp32c3-hal/examples is broken. This PR removes the url, adds a description of how to check example compatibility of specific SOC.

@HaoboGu HaoboGu mentioned this pull request Mar 21, 2024
Merged
SergioGasquez
SergioGasquez approved these changes Mar 22, 2024
View reviewed changes
Copy link
Member

@SergioGasquez SergioGasquez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution, good catch! Just added a small modification to defer to the readme instead of going into much detail here.

src/writing-your-own-application/nostd.md Outdated Show resolved Hide resolved
src/writing-your-own-application/nostd.md Show resolved Hide resolved
HaoboGu and others added 2 commits March 22, 2024 18:49
@SergioGasquez SergioGasquez merged commit a485f31 into esp-rs:main Mar 22, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SergioGasquez SergioGasquez SergioGasquez approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@HaoboGu @SergioGasquez