Skip to content

Reimplement ESO querying functions to use TAP / ADQL #2

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 158 commits into from
May 30, 2025
Merged

Reimplement ESO querying functions to use TAP / ADQL #2

merged 158 commits into from
May 30, 2025

Conversation

juanmcloaiza
Copy link
Collaborator

Reference PR to the official astroquery repo: astropy#3141

juanmcloaiza and others added 30 commits May 30, 2025 11:43
@juanmcloaiza
Delete this commit - message on __init__ EsoClass
c7ae3f7
@juanmcloaiza
Switch to TAP list_surveys and list_instruments
d469be8
@juanmcloaiza
Define tap_url as static method
971c5d1
@juanmcloaiza
Deselect ALMA at query level - TEMPORAL SOLUTION
06e3264
@juanmcloaiza
Mark list_surveys as deprecated; define list_collections
974d218
@juanmcloaiza
Add name of the new function to deprecation warning
182ce0b
@juanmcloaiza
Deprecate list_ and query_ _surveys in favor of _collections
6092c34
@juanmcloaiza
Replace 'survey' by 'collection' accross eso module
4f6c6fa
@juanmcloaiza
Make Pep8-compliant
eafcae9
@juanmcloaiza
Use astroquery deprecated decorator
38590a9
@juanmcloaiza
Accept argument 'surveys=' when calling *_surveys() deprecated functions
79843ad
@juanmcloaiza
Remove unused imports
9ee58c7
@juanmcloaiza
query_surveys --> query_collections in test_eso.py
9a71607
@juanmcloaiza
Update CHANGES.rst
dea1443
@juanmcloaiza
Add test_tap_url()
6d34286
@juanmcloaiza
Remove hard-coded queries iside user-exposed functions
88f51aa
@juanmcloaiza
Remove function _activate_form
15866d0
@juanmcloaiza
Develop py2adql function with tests
1cea70a
@juanmcloaiza
Handle coord1 and coord2 arguments in query_collections
aead4c7
@juanmcloaiza
Remove intersects arg from py2adql
2a85df7
@juanmcloaiza
Write TAP enabled query_collections; pass existing tests
b436e90
@juanmcloaiza
Remove intersects arg from py2adql test - not its responsibility
d4b9f26
@juanmcloaiza
Add ATLASGAL to SGRA_COLLECTIONS
af2b503
@juanmcloaiza
Write test for func query_tap_service
0fbef0c
@juanmcloaiza
Define and use _query_tap_service
fd79a3a
@juanmcloaiza
fwd query_instrument and _collections to query_instrument_or_collection
5b8ab2c
@juanmcloaiza
Ignore DALOverflowWarning with more granularity
8e75791
@juanmcloaiza
Remove unused code
63b0804
@juanmcloaiza
Take instrument or collection data from the corresponding table
2e53c81
@juanmcloaiza
Ignore DALOverflowWarning on remote tests
546ad4a
juanmcloaiza and others added 28 commits May 30, 2025 11:43
@juanmcloaiza
Add docstrings to list_instruments and list_surveys
8d0aacd
@juanmcloaiza
Update query_surveys docstring
8734ffd
@juanmcloaiza
Update docstring: query_surveys
ee6134e
@juanmcloaiza
Update docstrings for query_main and query_instrument
bae22f4
@juanmcloaiza
Make tap_url method private
16a0e99
@juanmcloaiza
Add docstring to query_tap_service
7483604
@juanmcloaiza
Update docstring query_tap_service
334c80e
@juanmcloaiza
Remove description col from table help output
747060d
@juanmcloaiza
Update ESO docs
bab1dc7
@juanmcloaiza
Update CHANGES.rst
b68e3e2
@juanmcloaiza
Implement query_apex_quicklooks
fa4ba95
@juanmcloaiza
Remove args from apex_quicklooks - ra, dec, radius
6a585c9
@juanmcloaiza
Rename args ra, dec, radius --> cone_[xxx]
920fa42
@juanmcloaiza
Update error message on query fails
dbeed4d
@juanmcloaiza
fix: cone search ignored when cone_ra=0
a71c5c4
@juanmcloaiza
Check type in maxrec setter
5a45882
@juanmcloaiza
Reorder columns before returning results
6df2c21
@juanmcloaiza
Reorder columns before returning the table
ba95272
@juanmcloaiza
pep8
d23b30f
@juanmcloaiza
Allow TAP operators on column_filters (#5)
7a7cf43
@juanmcloaiza
Add missing blank line to CHANGES.rst
6ea7b1f
@juanmcloaiza
Add 'not in' and 'not like' to supported TAP operators
296e9a4
@juanmcloaiza
Update documentation and docstrings
4c9ce99
@juanmcloaiza
Update documentation
feba734
@juanmcloaiza
docs: add warning and column_filters fix
3f64344
@juanmcloaiza
Fix: 'instrument' interpreted as filter 'in strument'
c732bae
@juanmcloaiza
pep8
08c7b65
@juanmcloaiza
Fix: 'instrument' interpreted as filter 'in strument'
0929318
@juanmcloaiza juanmcloaiza merged commit 0242cb0 into eso:develop May 30, 2025
9 of 10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
no-changelog-entry-needed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@juanmcloaiza