Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix -Wformat-y2k error #1714

Merged
merged 2 commits into from
Jun 27, 2024
Merged

fix -Wformat-y2k error #1714

merged 2 commits into from
Jun 27, 2024

Conversation

neheb
Copy link
Contributor

@neheb neheb commented Jun 8, 2024

%c potentially prints a 2 digit year. Just use a normal format.

  • Version of iperf3 (or development branch, such as master or
    3.1-STABLE) to which this pull request applies:
    all

  • Issues fixed (if any):

  • -Wformat-y2k error

  • Brief description of code changes (suitable for use as a commit message):
    %c potentially prints a 2 digit year. Just use a normal format.

%c potentially prints a 2 digit year. Just use a normal format.
@bmah888
Copy link
Contributor

bmah888 commented Jun 27, 2024

The problem here isn't exactly that %c is used as a format string, but more that we allow the user to specify an argument to --timestamp that includes the user's specification of a format string (i.e. --timestamp="%Y-%m-%d %H:%M:%S"). Going to fix that instead.

@bmah888 bmah888 self-assigned this Jun 27, 2024
This change provides consistent behavior relative to more routine
(non-error) timestamped output.
@bmah888 bmah888 merged commit f52bfa3 into esnet:master Jun 27, 2024
3 checks passed
@bmah888
Copy link
Contributor

bmah888 commented Jun 27, 2024

Pushed amended pull request. Thanks!

@neheb neheb deleted the patch-2 branch June 27, 2024 21:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants