Skip to content

Conversation

@Pixel998
Copy link
Contributor

@Pixel998 Pixel998 commented Jan 7, 2026

Prerequisites checklist

What is the purpose of this pull request?

This PR configures knip to properly recognize public API types in src/types.ts files so they aren't incorrectly flagged as unused exports. These types are meant for external consumption by package users, even if they're not used internally within our codebase.

What changes did you make? (Give an overview)

Added src/types.ts to the knip entry configuration for four packages that export public types:

  • @eslint/config-array
  • @eslint/config-helpers
  • @eslint/migrate-config
  • @eslint/plugin-kit

The @eslint/object-schema package already had this configuration.

Related Issues

#351

Is there anything you'd like reviewers to focus on?

@github-project-automation github-project-automation bot moved this to Needs Triage in Triage Jan 7, 2026
@fasttime fasttime moved this from Needs Triage to Triaging in Triage Jan 10, 2026
@fasttime
Copy link
Member

I believe knip is already recognizing src/types.ts files; otherwise it would flag them as unused. The issue in #351 seems to be an unreferenced type definition. I’ve added a comment on the PR with a possible fix.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

Status: Triaging

Development

Successfully merging this pull request may close these issues.

3 participants