Skip to content

ci: ensure the auto-created release-please action runs CI #342

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
nzakas merged 3 commits into from
Dec 29, 2025
Merged

ci: ensure the auto-created release-please action runs CI #342

Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
1af7b25
ci: ensure the auto-created `release-please` action runs CI
lumirlumir Dec 15, 2025
3e8e68b
wip: Update release-please.yml to include id-token permissions
lumirlumir Dec 15, 2025
c36f89f
wip: Add read permission for contents in workflow
lumirlumir Dec 23, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 1 addition & 3 deletions .github/workflows/release-please.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,8 +6,6 @@ on:
name: release-please

permissions:
contents: write
Copy link
Member

@mdjermanovic mdjermanovic Dec 18, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same as eslint/js#713 (comment).

Copy link
Member Author

@lumirlumir lumirlumir Dec 23, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've updated it in c36f89f.

pull-requests: write
id-token: write

jobs:
Expand All @@ -17,7 +15,7 @@ jobs:
- uses: googleapis/release-please-action@v4
id: release
with:
token: ${{secrets.GITHUB_TOKEN}}
token: ${{ secrets.WORKFLOW_PUSH_BOT_TOKEN }}

# Output which releases were created
- name: Output release info
Expand Down