chore: add lint:unused script to run Knip #241
Conversation
|
Oops, it looks like there are quite a few merge conflicts. Whenever you have some time, could you take a look? 😄 |
|
Hi everyone, it looks like we lost track of this pull request. Please review and see what the next steps are. This pull request will auto-close in 7 days without an update. |
|
🤔 CI is reporting... ...but I don't see where this would be newly coming from in this PR. Which is up-to-date from |
lumirlumir
left a comment
lumirlumir
left a comment
There was a problem hiding this comment.
Overall, this looks really good to me. 👍
I've left a few suggestions about the changes.
Co-authored-by: 루밀LuMir <[email protected]>
Co-authored-by: 루밀LuMir <[email protected]>
Co-authored-by: 루밀LuMir <[email protected]>
lumirlumir
left a comment
lumirlumir
left a comment
There was a problem hiding this comment.
LGTM, thanks!
Would like another review before merging.
|
friendly ping @JoshuaKGoldberg |
have you tried adding |
Co-authored-by: Percy Ma <[email protected]>
|
👍 updated and passing. |
lumirlumir
left a comment
lumirlumir
left a comment
There was a problem hiding this comment.
LGTM — re-approving.
Since this PR includes changes to the manual-publish.yml file, I’d appreciate it if @eslint/eslint-tsc, @kecrily, and @aladdin-add could re-review and confirm the changes before merging.
lumirlumir
requested review from
aladdin-add and
kecrily
and removed request for
kecrily
| run: | | ||
| if [ -f "jsr.json" ]; then | ||
| npx jsr publish | ||
| npx -y jsr publish |
There was a problem hiding this comment.
It seems that everywhere else uses jsr@latest, only this one doesn't have @latest. 🤔
| "outDir": "dist/esm" | ||
| "outDir": "dist/esm", | ||
| "types": ["mocha", "node"] | ||
| } |
There was a problem hiding this comment.
Given these packages are all using mocha, I was wondering if we could move it to tsconfig.base.json? (That way we wouldn't have to add it in each package's tsconfig.json)
4 participants
Prerequisites checklist
What is the purpose of this pull request?
Adds Knip to check for unused exports, unused dependencies, and missing dependencies
What changes did you make? (Give an overview)
-yto the jsr launch to explicitly always run it without promptingIs there anything you'd like reviewers to focus on?
Because this repo is a monorepo, its Knip config is a bit more complex than other repos'. I think I got the entry and project properties correct but I'm not positive.