Skip to content

build: Fix JSR publish for eslint/core #199

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

build: Fix JSR publish for eslint/core #199

wants to merge 1 commit into from

Conversation

nzakas
Copy link
Member

@nzakas nzakas commented May 1, 2025

Prerequisites checklist

What is the purpose of this pull request?

Added json-schema as a dev dependency to @eslint/core. This is needed in order to satisfy JSR's publish requirements.

Related Issues

Is there anything you'd like reviewers to focus on?

@github-project-automation github-project-automation bot moved this to Needs Triage in Triage May 1, 2025
@mdjermanovic
Copy link
Member

This is needed in order to satisfy JSR's publish requirements.

Was there an attempt to publish @eslint/core that failed because of this, and how come the problem isn't caught by the Verify JSR Publish check on the main branch?

https://github.com/eslint/rewrite/actions/runs/14777933672/job/41490237062

@nzakas
Copy link
Member Author

nzakas commented May 1, 2025

@mdjermanovic yes, I posted in Discord about it.

There are a number of issues with jsr public --dry-run where it's not catching things that actually fail when a live publish is attempted. There are multiple bugs open in the JSR repo regarding this.

Copy link
Member

@mdjermanovic mdjermanovic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The change LGTM if it's needed (not sure how to verify if it isn't caught by --dry-run).

@nzakas
Copy link
Member Author

nzakas commented May 2, 2025

You can run npx jsr publish locally. Because we can't republish and existing version, it will go through the entire process and when it realizes the version already exists, it will skip the very last part.

@nzakas nzakas moved this from Needs Triage to Implementing in Triage May 2, 2025
@mdjermanovic
Copy link
Member

It doesn't reproduce the problem for me:

$ npx jsr publish
Need to install the following packages:
[email protected]
Ok to proceed? (y) y

Downloading JSR release binary...
[00:01] [#################################################>] 39.5 MiB/40.0 MiB
Checking for slow types in the public API...
Visit https://jsr.io/auth?code=<redacted> to authorize publishing of @eslint/core
Waiting...
Authorization successful. Authenticated as Milos Djermanovic
Publishing @eslint/[email protected] ...
Warning: Skipping, already published @eslint/[email protected]

Completed in 41s

@nzakas
Copy link
Member Author

nzakas commented May 5, 2025

Sorry, are you saying you can't reproduce before this PR? Or after?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: Implementing
Development

Successfully merging this pull request may close these issues.

2 participants