-
-
Notifications
You must be signed in to change notification settings - Fork 220
refactor: use release-please to update exported version
#714
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from 1 commit
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
This file was deleted.
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,29 @@ | ||
| /** | ||
| * @fileoverview Tests for version. | ||
| * @author Milos Djermanovic | ||
| */ | ||
|
|
||
| //------------------------------------------------------------------------------ | ||
| // Requirements | ||
| //------------------------------------------------------------------------------ | ||
|
|
||
| import { expect } from "chai"; | ||
| import * as eslintScope from "../lib/index.js"; | ||
| import { fileURLToPath } from "node:url"; | ||
| import path from "node:path"; | ||
| import fs from "node:fs"; | ||
|
|
||
| // eslint-disable-next-line no-underscore-dangle -- Conventional | ||
| const __dirname = path.dirname(fileURLToPath(import.meta.url)); | ||
|
|
||
| const { version } = JSON.parse(fs.readFileSync(`${__dirname}/../package.json`, "utf8")); | ||
mdjermanovic marked this conversation as resolved.
Outdated
Show resolved
Hide resolved
|
||
|
|
||
| //------------------------------------------------------------------------------ | ||
| // Tests | ||
| //------------------------------------------------------------------------------ | ||
|
|
||
| describe("version", () => { | ||
| it("should be equal to the version in package.json", () => { | ||
| expect(eslintScope.version).to.be.equal(version); | ||
| }); | ||
| }); | ||
This file was deleted.
This file was deleted.
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,29 @@ | ||
| /** | ||
| * @fileoverview Tests for version. | ||
| * @author Milos Djermanovic | ||
| */ | ||
|
|
||
| //------------------------------------------------------------------------------ | ||
| // Requirements | ||
| //------------------------------------------------------------------------------ | ||
|
|
||
| import * as espree from "../../espree.js"; | ||
| import { fileURLToPath } from "node:url"; | ||
| import path from "node:path"; | ||
| import fs from "node:fs"; | ||
| import assert from "node:assert"; | ||
|
|
||
| // eslint-disable-next-line no-underscore-dangle -- Conventional | ||
| const __dirname = path.dirname(fileURLToPath(import.meta.url)); | ||
|
|
||
| const { version } = JSON.parse(fs.readFileSync(`${__dirname}/../../package.json`, "utf8")); | ||
|
||
|
|
||
| //------------------------------------------------------------------------------ | ||
| // Tests | ||
| //------------------------------------------------------------------------------ | ||
|
|
||
| describe("version", () => { | ||
| it("should be equal to the version in package.json", () => { | ||
| assert.strictEqual(espree.version, version); | ||
| }); | ||
| }); | ||
This file was deleted.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We're already running
buildbefore publishing:js/.github/workflows/release-please.yml
Lines 44 to 47 in 04247cb