Skip to content

Conversation

Pixel998
Copy link
Contributor

@Pixel998 Pixel998 commented Sep 21, 2025

Prerequisites checklist

What is the purpose of this pull request?

Remove the ecmaFeatures.globalReturn option from the Playground to stay compatible with the next ESLint release, where this option will be removed.

What changes did you make? (Give an overview)

Removed globalReturn from the ECMA features allowlist

Related Issues

eslint/eslint#20145

Is there anything you'd like reviewers to focus on?

@github-project-automation github-project-automation bot moved this to Needs Triage in Triage Sep 21, 2025
Copy link

netlify bot commented Sep 21, 2025

Deploy Preview for new-eslint ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit 67dce3a
🔍 Latest deploy log https://app.netlify.com/projects/new-eslint/deploys/68cfb540e95c3700083abd57
😎 Deploy Preview https://deploy-preview-785--new-eslint.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

Copy link

netlify bot commented Sep 21, 2025

Deploy Preview for fr-eslint ready!

Name Link
🔨 Latest commit 67dce3a
🔍 Latest deploy log https://app.netlify.com/projects/fr-eslint/deploys/68cfb54032200400089878cb
😎 Deploy Preview https://deploy-preview-785--fr-eslint.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@eslint-github-bot eslint-github-bot bot added the bug Something isn't working label Sep 21, 2025
Copy link

netlify bot commented Sep 21, 2025

Deploy Preview for ja-eslint ready!

Name Link
🔨 Latest commit 67dce3a
🔍 Latest deploy log https://app.netlify.com/projects/ja-eslint/deploys/68cfb5404286f5000827646b
😎 Deploy Preview https://deploy-preview-785--ja-eslint.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

Copy link

netlify bot commented Sep 21, 2025

Deploy Preview for pt-br-eslint ready!

Name Link
🔨 Latest commit 67dce3a
🔍 Latest deploy log https://app.netlify.com/projects/pt-br-eslint/deploys/68cfb54098181400074704e8
😎 Deploy Preview https://deploy-preview-785--pt-br-eslint.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

Copy link

netlify bot commented Sep 21, 2025

Deploy Preview for zh-hans-eslint ready!

Name Link
🔨 Latest commit 67dce3a
🔍 Latest deploy log https://app.netlify.com/projects/zh-hans-eslint/deploys/68cfb5400c7b270008361228
😎 Deploy Preview https://deploy-preview-785--zh-hans-eslint.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

Copy link

netlify bot commented Sep 21, 2025

Deploy Preview for hi-eslint ready!

Name Link
🔨 Latest commit 67dce3a
🔍 Latest deploy log https://app.netlify.com/projects/hi-eslint/deploys/68cfb540c2958b00086de7b9
😎 Deploy Preview https://deploy-preview-785--hi-eslint.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

Copy link

netlify bot commented Sep 21, 2025

Deploy Preview for es-eslint ready!

Name Link
🔨 Latest commit 67dce3a
🔍 Latest deploy log https://app.netlify.com/projects/es-eslint/deploys/68cfb540b24edc00086b6acc
😎 Deploy Preview https://deploy-preview-785--es-eslint.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

Copy link

netlify bot commented Sep 21, 2025

Deploy Preview for de-eslint ready!

Name Link
🔨 Latest commit 67dce3a
🔍 Latest deploy log https://app.netlify.com/projects/de-eslint/deploys/68cfb5400c7b27000836122d
😎 Deploy Preview https://deploy-preview-785--de-eslint.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

Copy link
Member

@mdjermanovic mdjermanovic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks! This would need to wait until ESLint v10.0.0 final (not a pre-release) is released.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Blocked
Development

Successfully merging this pull request may close these issues.

2 participants