Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Make npm install work #51

Closed
wants to merge 1 commit into from
Closed

Fix: Make npm install work #51

wants to merge 1 commit into from

Conversation

nzakas
Copy link
Member

@nzakas nzakas commented Apr 23, 2021

npm install isn't working due to peer dependencies in eslint-config-eslint, which is throwing npm 7 into a rage.

This just remove eslint-config-eslint for now so we can start developing again. The real fix is to update eslint-config-eslint.

@eslint-github-bot
Copy link

Hi @nzakas!, thanks for the Pull Request

The first commit message isn't properly formatted. We ask that you update the message to match this format, as we use it to generate changelogs and automate releases.

  • The commit message tag must be one of the following:

    The Tag is one of the following:

    • Fix - for a bug fix.
    • Update - either for a backwards-compatible enhancement or for a rule change that adds reported problems.
    • New - implements a new feature.
    • Breaking - for a backwards-incompatible enhancement or feature.
    • Docs - changes to documentation only.
    • Build - changes to build process only.
    • Upgrade - for a dependency upgrade.
    • Chore - for anything that isn't user-facing (for example, refactoring, adding tests, etc.).

    You can use the labels of the issue you are working on to determine the best tag.

  • There should be a space following the initial tag and colon, for example 'New: Message'.

  • The first letter of the tag should be in uppercase

Read more about contributing to ESLint here

@nzakas nzakas changed the title fix: Make npm install work Fix: Make npm install work Apr 23, 2021
@@ -1,5 +1,7 @@
env:
node: true
extends: "eslint-config-eslint"
# extends: "eslint-config-eslint"
Copy link
Member

@aladdin-add aladdin-add Apr 23, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it will disable all rules in the config. can we just use npm install --force for the time being - util the issue was fixed in eslint-config-eslint?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That didn’t work when I tried. I’d just like to get unblocked. We will be retiring this utility soon so I’m not too concerned if linting is unavailable for a bit.

@@ -39,8 +39,7 @@
"homepage": "https://github.com/eslint/eslint-release#readme",
"devDependencies": {
"chai": "^4.2.0",
"eslint": "^5.16.0",
"eslint-config-eslint": "^5.0.1",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We were using an old version of eslint-config-eslint, the peer deps issue has been fixed in v7.0.0.

Can we upgrade to 7.0.0 instead of removing it? I made PR #54, and it seems to work on Node 15 and Node 16.

@nzakas
Copy link
Member Author

nzakas commented Apr 26, 2021

Closing in favor of #54.

@nzakas nzakas closed this Apr 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants