-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix: Make npm install work #51
Conversation
Hi @nzakas!, thanks for the Pull Request The first commit message isn't properly formatted. We ask that you update the message to match this format, as we use it to generate changelogs and automate releases.
Read more about contributing to ESLint here |
@@ -1,5 +1,7 @@ | |||
env: | |||
node: true | |||
extends: "eslint-config-eslint" | |||
# extends: "eslint-config-eslint" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it will disable all rules in the config. can we just use npm install --force
for the time being - util the issue was fixed in eslint-config-eslint
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That didn’t work when I tried. I’d just like to get unblocked. We will be retiring this utility soon so I’m not too concerned if linting is unavailable for a bit.
@@ -39,8 +39,7 @@ | |||
"homepage": "https://github.com/eslint/eslint-release#readme", | |||
"devDependencies": { | |||
"chai": "^4.2.0", | |||
"eslint": "^5.16.0", | |||
"eslint-config-eslint": "^5.0.1", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We were using an old version of eslint-config-eslint
, the peer deps issue has been fixed in v7.0.0.
Can we upgrade to 7.0.0
instead of removing it? I made PR #54, and it seems to work on Node 15 and Node 16.
Closing in favor of #54. |
npm install
isn't working due to peer dependencies ineslint-config-eslint
, which is throwing npm 7 into a rage.This just remove
eslint-config-eslint
for now so we can start developing again. The real fix is to updateeslint-config-eslint
.