Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update: Remove specific branch from git push (fixes #42) #43

Merged
merged 1 commit into from
Aug 24, 2020
Merged

Conversation

nzakas
Copy link
Member

@nzakas nzakas commented Aug 20, 2020

This removes the origin master part of the git push command during a release. This should allow us to use the current branch instead of always master, which will facilitate the change over to using main as the primary branch.

@kaicataldo
Copy link
Member

kaicataldo commented Aug 20, 2020

Tangentially, should this be a breaking change? Trying to think of what downsides might exist to pushing a branch that isn't called master to a remote and am not coming up with anything...

@nzakas
Copy link
Member Author

nzakas commented Aug 20, 2020

Git automatically pushes to origin and automatically matches the branch to the current one, so in theory this should not be a breaking change.

@nzakas nzakas merged commit 7330f24 into master Aug 24, 2020
@nzakas nzakas deleted the issue42 branch August 24, 2020 17:55
@nzakas
Copy link
Member Author

nzakas commented Aug 24, 2020

Did a release with this and it worked!
https://github.com/eslint/eslint-release/releases/tag/v3.1.0

🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants