Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Breaking: require node >= 8.0 & upgrade eslint-config-eslint #34

Merged
merged 7 commits into from
Jun 22, 2019
Merged

Breaking: require node >= 8.0 & upgrade eslint-config-eslint #34

merged 7 commits into from
Jun 22, 2019

Conversation

aladdin-add
Copy link
Member

@aladdin-add aladdin-add commented Feb 19, 2019 •
edited
Loading

  • dorp support 0.x 4.x
  • upgrade some deps

kaicataldo
kaicataldo approved these changes Apr 22, 2019
View reviewed changes
Copy link
Member

@kaicataldo kaicataldo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

platinumazure
platinumazure suggested changes Apr 22, 2019
View reviewed changes
Copy link
Member

@platinumazure platinumazure left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall LGTM, just a few suggestions. Thanks!

@aladdin-add @platinumazure
Update lib/release-ops.js
a8670e1 
Co-Authored-By: Kevin Partington <[email protected]>
@kaicataldo
Copy link
Member

Friendly ping 👋 . Do we want to try to land this still?

@platinumazure
Copy link
Member

@kaicataldo I had a concern about an // eslint-disable-line with no rules listed, which I was hoping would be addressed but it doesn't seem to be addressed yet.

@aladdin-add Am I missing anything?

@kaicataldo
Copy link
Member

I also think it's a good practice to be explicit about what rules are being disabled. 👍

@aladdin-add
Copy link
Member Author

oops, sorry. I missed it somehow, will update it later

@aladdin-add aladdin-add changed the title Breaking: require node >= 6.0 & upgrade eslint-config-eslint Breaking: require node >= 8.0 & upgrade eslint-config-eslint Jun 21, 2019
@aladdin-add
Copy link
Member Author

just updated to require Node.js >=8, as Node.js v6 has been EOL.

@aladdin-add aladdin-add merged commit 8cde736 into master Jun 22, 2019
@aladdin-add aladdin-add deleted the upgrade branch June 22, 2019 06:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@platinumazure platinumazure platinumazure approved these changes

@kaicataldo kaicataldo Awaiting requested review from kaicataldo

Assignees
No one assigned
Labels
triage
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@aladdin-add @kaicataldo @platinumazure