Skip to content

Added Ship Tree group IDs - #203

Merged
Nohus merged 1 commit into
mainfrom
ship_tree_groups
Aug 24, 2025
Merged

Added Ship Tree group IDs#203
Nohus merged 1 commit into
mainfrom
ship_tree_groups

Conversation

@Nohus

@Nohus Nohus commented Aug 24, 2025

Copy link
Copy Markdown
Contributor

No description provided.

@Nohus
Nohus requested review from a team as code owners August 24, 2025 13:46
@GoldenGnu

Copy link
Copy Markdown
Member

A little feedback:

  1. If this data is already in the SDE, I think it's a mistake to duplicate it here, as there is a change it will be become outdated on changes. In my opinion, This should only contain meta id ranges, that are not in the SDE.
  2. I think it's confusing to use the word Tree here, I would prefer Ship Group ID.

Feel free to totalt disregard this feedback, you're doing an amazing job with the documentation, this is just my opinion and It's fine if you do not agree :)

@Nohus

Nohus commented Aug 24, 2025

Copy link
Copy Markdown
Contributor Author

@GoldenGnu

  1. The data is not in the SDE to my knowledge
  2. These are not the Ship Group IDs, which are in the SDE but are different

@Nohus
Nohus merged commit 829ceb3 into main Aug 24, 2025
1 check passed
@Nohus
Nohus deleted the ship_tree_groups branch August 24, 2025 14:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants