Skip to content

fix(desktop): sidebar toggle button hidden after collapse #3141

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
HUQIANTAO wants to merge 1 commit into from
Closed

fix(desktop): sidebar toggle button hidden after collapse #3141

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion desktop/frontend/src/App.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -695,7 +695,12 @@ export default function App() {
<aside className={`sidebar${sidebarCollapsed ? " sidebar--collapsed" : ""}`} aria-label={t("sidebar.navigation")}>
<div className="sidebar__brand">
<img src={logo} alt="" className="sidebar__logo" />
<span>Reasonix</span>
{/* sidebar__brand-name is the only span we want to hide when the rail
collapses — the Tooltip wrapper around the toggle button is also a
<span>, so a generic `.sidebar__brand > span { display: none }` rule
would also hide the toggle and lock the sidebar closed. This class
keeps the selector targeted. See PR #2987 for the original incident. */}
<span className="sidebar__brand-name">Reasonix</span>
<Tooltip label={sidebarToggleTitle}>
<button
className={`sidebar__toggle${sidebarExpandBlocked ? " sidebar__toggle--blocked" : ""}`}
Expand Down
12 changes: 11 additions & 1 deletion desktop/frontend/src/styles.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -665,9 +665,19 @@ body {
width: 100%;
padding: 0 0 8px;
}
.sidebar--collapsed .sidebar__brand > span {
/* Hide only the brand text when the rail collapses. The previous selector
(`.sidebar--collapsed .sidebar__brand > span`) also matched the Tooltip
wrapper around the toggle button, which made the sidebar impossible to
reopen once collapsed. The dedicated class keeps the rule targeted; the
defensive `.tooltip-trigger` override below is a belt-and-suspenders guard
so a future regression in the brand-name selector cannot lock the rail
closed again. See PR #2987 for the original incident. */
.sidebar--collapsed .sidebar__brand-name {
display: none;
}
.sidebar--collapsed .sidebar__brand .tooltip-trigger {
display: inline-flex;
}
.sidebar--collapsed .sidebar__toggle {
margin-left: 0;
width: var(--sidebar-rail-item-size);
Expand Down
Loading