feat(desktop): settings search input (section-level filter)#3119
Open
HUQIANTAO wants to merge 1 commit into
Open
feat(desktop): settings search input (section-level filter)#3119HUQIANTAO wants to merge 1 commit into
HUQIANTAO wants to merge 1 commit into
Conversation
github-actions
Bot
added
the
v2
The settings drawer has grown to six sections (Models / Permissions
/ Sandbox / Agent / Appearance / Updates). Finding a specific
field meant scrolling the whole list. Add a search input below
the drawer header that hides sections whose title doesn't match
the query.
The match is section-level (case-insensitive substring) — a query
of 'model' shows Models & Providers only; 'permiss' shows
Permissions only. Per-field matching (matching the placeholder
text inside a section) is a follow-up: it needs a section schema
exporting its search text, which the section components don't
yet expose. Section-level is enough to ship the affordance and
covers the common 'where is the X setting' path.
When the query hides every section, an empty-state message names
the query so the user knows the filter is the reason (not a
broken config). The input reuses the hist-search styles added in
PR-18, so the visual treatment is consistent across drawers.
i18n: en + zh both gain settings.searchPlaceholder and
settings.noSectionMatch (with a {q} placeholder for the literal
query).
HUQIANTAO
force-pushed
the
feat/settings-search
branch
from
fa353c4 to
01fbb49
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The settings drawer has grown to six sections (Models / Permissions / Sandbox / Agent / Appearance / Updates). Finding a specific field meant scrolling the whole list. Add a search input below the drawer header that hides sections whose title doesn't match the query.
The match is section-level (case-insensitive substring). Per-field matching is a follow-up: it needs a section schema exporting its search text, which the section components don't yet expose.
When the query hides every section, an empty-state message names the query so the user knows the filter is the reason (not a broken config).